Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: third_party/WebKit/public/web/WebMIDIClient.h

Issue 1602703005: Web MIDI: Ask permissions of the content layer always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: split changes outside blink Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebMIDIClient.h
diff --git a/third_party/WebKit/public/web/WebMIDIClient.h b/third_party/WebKit/public/web/WebMIDIClient.h
index 7ae72aefe368b22714410fbb11103f928f601030..452ea17a782f436e077e84c29037932358daaee0 100644
--- a/third_party/WebKit/public/web/WebMIDIClient.h
+++ b/third_party/WebKit/public/web/WebMIDIClient.h
@@ -31,6 +31,8 @@
#ifndef WebMIDIClient_h
#define WebMIDIClient_h
+#include "WebMIDIOptions.h"
mlamouri (slow - plz ping) 2016/01/22 11:54:43 nit: I think you can make this a forward declare.
Takashi Toyoshima 2016/01/26 07:24:52 Done.
+
namespace blink {
class WebMIDIPermissionRequest;
@@ -39,17 +41,17 @@ class WebMIDIClient {
public:
virtual ~WebMIDIClient() { }
- // Request a permission to use system exclusive messages. Called when
- // MIDIOptions.sysex is true.
+ // Request a permission to use MIDI system. Called when requestMIDIAccess()
+ // is called with any option.
// Once the request is done, any WebMIDIPermissionRequest instances equal to
// |request| must not be accessed after that.
- virtual void requestSysexPermission(const WebMIDIPermissionRequest& /* request */) = 0;
+ virtual void requestPermission(const WebMIDIPermissionRequest& /* request */, const WebMIDIOptions& /* options */) = 0;
// Cancel the request since the requesting frame may be moving to
// a new page.
// Once canceled, any WebMIDIPermissionRequest instances equal to
// |request| must not be accessed after that.
- virtual void cancelSysexPermissionRequest(const WebMIDIPermissionRequest& /* request */) = 0;
+ virtual void cancelPermissionRequest(const WebMIDIPermissionRequest& /* request */) = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698