Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: content/renderer/media/midi_dispatcher.cc

Issue 1602703005: Web MIDI: Ask permissions of the content layer always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert layout_test_message_filter.cc that should be in the next CL Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/midi_dispatcher.h" 5 #include "content/renderer/media/midi_dispatcher.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "content/public/common/service_registry.h" 8 #include "content/public/common/service_registry.h"
9 #include "content/public/renderer/render_frame.h" 9 #include "content/public/renderer/render_frame.h"
10 #include "third_party/WebKit/public/platform/WebString.h" 10 #include "third_party/WebKit/public/platform/WebString.h"
11 #include "third_party/WebKit/public/web/WebSecurityOrigin.h" 11 #include "third_party/WebKit/public/web/WebSecurityOrigin.h"
12 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h" 12 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
13 #include "third_party/WebKit/public/web/modules/webmidi/WebMIDIOptions.h"
13 #include "third_party/WebKit/public/web/modules/webmidi/WebMIDIPermissionRequest .h" 14 #include "third_party/WebKit/public/web/modules/webmidi/WebMIDIPermissionRequest .h"
14 15
15 using blink::WebMIDIPermissionRequest; 16 using blink::WebMIDIPermissionRequest;
17 using blink::WebMIDIOptions;
16 using blink::WebSecurityOrigin; 18 using blink::WebSecurityOrigin;
17 19
18 namespace content { 20 namespace content {
19 21
20 MidiDispatcher::MidiDispatcher(RenderFrame* render_frame) 22 MidiDispatcher::MidiDispatcher(RenderFrame* render_frame)
21 : RenderFrameObserver(render_frame) { 23 : RenderFrameObserver(render_frame) {
22 } 24 }
23 25
24 MidiDispatcher::~MidiDispatcher() {} 26 MidiDispatcher::~MidiDispatcher() {}
25 27
26 void MidiDispatcher::requestSysexPermission( 28 void MidiDispatcher::requestPermission(const WebMIDIPermissionRequest& request,
27 const WebMIDIPermissionRequest& request) { 29 const WebMIDIOptions& options) {
30 if (options.sysex == WebMIDIOptions::SysexPermission::WithoutSysex)
31 return WebMIDIPermissionRequest(request).setIsAllowed(true);
32
28 if (!permission_service_.get()) { 33 if (!permission_service_.get()) {
29 render_frame()->GetServiceRegistry()->ConnectToRemoteService( 34 render_frame()->GetServiceRegistry()->ConnectToRemoteService(
30 mojo::GetProxy(&permission_service_)); 35 mojo::GetProxy(&permission_service_));
31 } 36 }
32 37
33 int permission_request_id = 38 int permission_request_id =
34 requests_.Add(new WebMIDIPermissionRequest(request)); 39 requests_.Add(new WebMIDIPermissionRequest(request));
35 40
36 permission_service_->RequestPermission( 41 permission_service_->RequestPermission(
37 PermissionName::MIDI_SYSEX, request.securityOrigin().toString().utf8(), 42 PermissionName::MIDI_SYSEX, request.securityOrigin().toString().utf8(),
38 blink::WebUserGestureIndicator::isProcessingUserGesture(), 43 blink::WebUserGestureIndicator::isProcessingUserGesture(),
39 base::Bind(&MidiDispatcher::OnSysExPermissionSet, base::Unretained(this), 44 base::Bind(&MidiDispatcher::OnPermissionSet, base::Unretained(this),
40 permission_request_id)); 45 permission_request_id));
41 } 46 }
42 47
43 void MidiDispatcher::cancelSysexPermissionRequest( 48 void MidiDispatcher::cancelPermissionRequest(
44 const WebMIDIPermissionRequest& request) { 49 const WebMIDIPermissionRequest& request) {
45 for (Requests::iterator it(&requests_); !it.IsAtEnd(); it.Advance()) { 50 for (Requests::iterator it(&requests_); !it.IsAtEnd(); it.Advance()) {
46 WebMIDIPermissionRequest* value = it.GetCurrentValue(); 51 WebMIDIPermissionRequest* value = it.GetCurrentValue();
47 if (!value->equals(request)) 52 if (!value->equals(request))
48 continue; 53 continue;
49 requests_.Remove(it.GetCurrentKey()); 54 requests_.Remove(it.GetCurrentKey());
50 break; 55 break;
51 } 56 }
52 } 57 }
53 58
54 void MidiDispatcher::OnSysExPermissionSet(int request_id, 59 void MidiDispatcher::OnPermissionSet(int request_id, PermissionStatus status) {
55 PermissionStatus status) {
56 // |request| can be NULL when the request is canceled. 60 // |request| can be NULL when the request is canceled.
57 WebMIDIPermissionRequest* request = requests_.Lookup(request_id); 61 WebMIDIPermissionRequest* request = requests_.Lookup(request_id);
58 if (!request) 62 if (!request)
59 return; 63 return;
60 request->setIsAllowed(status == PermissionStatus::GRANTED); 64 request->setIsAllowed(status == PermissionStatus::GRANTED);
61 requests_.Remove(request_id); 65 requests_.Remove(request_id);
62 } 66 }
63 67
64 } // namespace content 68 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/midi_dispatcher.h ('k') | third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698