Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1602663003: Framelet Prototype 2016 using Mojo IPC

Created:
4 years, 11 months ago by Fady Samuel
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-html_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, nasko+codewatch_chromium.org, eae+blinkwatch, yzshen+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, rwlbuis, extensions-reviews_chromium.org, sdefresne+watchlist_chromium.org, jam, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, loading-reviews_chromium.org, dcheng, szager+layoutwatch_chromium.org, Nate Chapin, darin (slow to review), tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Framelet Prototype 2016 using Mojo IPC This CL replaces this earlier prototype that uses Chrome IPC: https://codereview.chromium.org/1560553002/ BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Restore unnecessary content changes #

Patch Set 4 : Even more cleanup #

Patch Set 5 : More cleanup #

Patch Set 6 : Rebased. Disabled oilpan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3507 lines, -263 lines) Patch
M cc/trees/layer_tree_settings.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 8 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 3 chunks +0 lines, -3 lines 0 comments Download
A chrome/browser/guest_view/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/browser/guest_view/chrome_content_browser_client_guest_view_part.h View 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/guest_view/chrome_content_browser_client_guest_view_part.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A + chrome/browser/guest_view/chrome_extensions_guest_view_manager_delegate.h View 2 chunks +9 lines, -8 lines 0 comments Download
A + chrome/browser/guest_view/chrome_extensions_guest_view_manager_delegate.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/guest_view/chrome_guest_view_manager_delegate.h View 1 chunk +32 lines, -13 lines 0 comments Download
M chrome/browser/guest_view/chrome_guest_view_manager_delegate.cc View 1 chunk +38 lines, -25 lines 0 comments Download
A chrome/browser/guest_view/chrome_guest_view_message_filter.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/guest_view/chrome_guest_view_message_filter.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 3 4 5 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.cc View 2 chunks +0 lines, -4 lines 0 comments Download
A chrome/renderer/guest_view/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/renderer/guest_view/chrome_guest_view_container_dispatcher.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/renderer/guest_view/chrome_guest_view_container_dispatcher.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_chromium_strings.grd View 1 chunk +5 lines, -0 lines 0 comments Download
M components/components_google_chrome_strings.grd View 1 chunk +5 lines, -0 lines 0 comments Download
A components/framelet.gypi View 1 chunk +80 lines, -0 lines 0 comments Download
A components/framelet/browser/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download
A components/framelet/browser/DEPS View 1 chunk +10 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_factory_impl.h View 1 chunk +61 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_factory_impl.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_guest.h View 1 2 3 4 1 chunk +92 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_guest.cc View 1 2 3 4 1 chunk +211 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_memory_tracker.h View 1 chunk +66 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_memory_tracker.cc View 1 chunk +103 lines, -0 lines 0 comments Download
A components/framelet/browser/framelet_memory_tracker_client.h View 1 chunk +21 lines, -0 lines 0 comments Download
A components/framelet/browser/resource_usage_range.h View 1 chunk +62 lines, -0 lines 0 comments Download
A components/framelet/browser/resource_usage_reporter.h View 1 chunk +68 lines, -0 lines 0 comments Download
A components/framelet/browser/resource_usage_reporter_base.h View 1 chunk +14 lines, -0 lines 0 comments Download
A components/framelet/browser/resource_usage_reporter_client.h View 1 chunk +29 lines, -0 lines 0 comments Download
A components/framelet/common/BUILD.gn View 1 chunk +36 lines, -0 lines 0 comments Download
A + components/framelet/common/DEPS View 1 chunk +3 lines, -2 lines 0 comments Download
A components/framelet/common/framelet.mojom View 1 chunk +86 lines, -0 lines 0 comments Download
A components/framelet/common/framelet_constants.h View 1 chunk +29 lines, -0 lines 0 comments Download
A components/framelet/common/framelet_constants.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A + components/framelet/common/framelet_message_generator.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/framelet/common/framelet_message_generator.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A components/framelet/common/framelet_messages.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
A + components/framelet/common/framelet_param_traits.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/framelet/common/value_type_converters.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/framelet/common/value_type_converters.cc View 1 2 3 4 5 1 chunk +77 lines, -0 lines 0 comments Download
A components/framelet/renderer/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A components/framelet/renderer/DEPS View 1 chunk +14 lines, -0 lines 0 comments Download
A components/framelet/renderer/framelet_container.h View 1 chunk +117 lines, -0 lines 0 comments Download
A components/framelet/renderer/framelet_container.cc View 1 2 3 4 5 1 chunk +262 lines, -0 lines 0 comments Download
A components/framelet_mojo_bindings.gyp View 1 chunk +32 lines, -0 lines 0 comments Download
M components/guest_view/browser/guest_view_base.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/guest_view/renderer/guest_view_container_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/resources/components_scaled_resources.grd View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
A + components/resources/default_100_percent/framelet/click_to_play.png View Binary file 0 comments Download
A components/resources/framelet_scaled_resources.grdp View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 6 chunks +13 lines, -7 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 12 chunks +106 lines, -53 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 2 chunks +10 lines, -0 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/browser/guest_host.h View 3 chunks +30 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A + content/public/test/web_input_event_traits_unittest.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 3 chunks +10 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_message_filter.h View 2 chunks +7 lines, -1 line 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_message_filter.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_start.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/OilpanExpectations View 1 2 3 4 5 1 chunk +61 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 8 chunks +13 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/build/features.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/config.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 4 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/Framelet.h View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/Framelet.cpp View 1 2 3 4 5 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/FrameletClient.h View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/FrameletView.h View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/frame/FrameletView.cpp View 1 chunk +104 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCollection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/html/HTMLFrameletElement.h View 1 chunk +37 lines, -25 lines 0 comments Download
A third_party/WebKit/Source/core/html/HTMLFrameletElement.cpp View 1 chunk +145 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/html/HTMLFrameletElement.idl View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLStackItem.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/LayoutFramelet.h View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/LayoutFramelet.cpp View 1 chunk +55 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Widget.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 5 4 chunks +10 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/FrameletClientImpl.h View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/FrameletClientImpl.cpp View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/WebFrameletImpl.h View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/WebFrameletImpl.cpp View 1 chunk +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/features.gni View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/WebFramelet.h View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/WebFrameletClient.h View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Fady Samuel
4 years, 11 months ago (2016-01-19 03:03:11 UTC) #1 
Description was changed from

==========
Framelet Prototype 2016 using Mojo IPC

This CL replaces this earlier prototype that uses Chrome IPC:

https://codereview.chromium.org/1560553002/

BUG=
==========

to

==========
Framelet Prototype 2016 using Mojo IPC

This CL replaces this earlier prototype that uses Chrome IPC:

https://codereview.chromium.org/1560553002/

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

Powered by Google App Engine
This is Rietveld 408576698