src/x64/lithium-codegen-x64.h - Issue 16026023: Avoid Unnecessary Smi Checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.h

Issue 16026023: Avoid Unnecessary Smi Checks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: address review Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.h

diff --git a/src/x64/lithium-codegen-x64.h b/src/x64/lithium-codegen-x64.h

index 116f8759b6f9b0405d079b0f6590f07ba2557436..c89ec1fd0eecf34a2914de0dfcaee70c5ab476c2 100644

--- a/src/x64/lithium-codegen-x64.h

+++ b/src/x64/lithium-codegen-x64.h

@@ -312,7 +312,8 @@ class LCodeGen BASE_EMBEDDED {

// true and false label should be made, to optimize fallthrough.

Condition EmitIsString(Register input,

- Label* is_not_string);

+ Label* is_not_string,

+ SmiCheck check_needed);

// Emits optimized code for %_IsConstructCall().

// Caller should branch on equal condition.

« no previous file with comments | « src/ia32/lithium-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »