Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/processor/minidump.cc

Issue 1602563003: Fix usage of snprintf for MSVC (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/common/stdio.h ('K') | « src/processor/logging.cc ('k') | src/processor/minidump_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/processor/minidump.cc
diff --git a/src/processor/minidump.cc b/src/processor/minidump.cc
index ccc90d5af8d8e156b05a0d04aeec4e6fffd6ecb1..a23a0165ed2ea844c3c21bbc553b3a85cf4508d9 100644
--- a/src/processor/minidump.cc
+++ b/src/processor/minidump.cc
@@ -38,15 +38,11 @@
#include <assert.h>
#include <fcntl.h>
#include <stddef.h>
-#include <stdio.h>
#include <string.h>
#include <time.h>
#ifdef _WIN32
#include <io.h>
-#if defined(_MSC_VER) && _MSC_VER < 1900
-#define snprintf _snprintf
-#endif
#else // _WIN32
#include <unistd.h>
#endif // _WIN32
@@ -60,6 +56,7 @@
#include "processor/range_map-inl.h"
#include "common/scoped_ptr.h"
+#include "common/stdio.h"
#include "google_breakpad/processor/dump_context.h"
#include "processor/basic_code_module.h"
#include "processor/basic_code_modules.h"
« src/common/stdio.h ('K') | « src/processor/logging.cc ('k') | src/processor/minidump_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698