Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: src/processor/minidump.cc

Issue 1602563003: Fix usage of snprintf for MSVC (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 Google Inc. 1 // Copyright (c) 2010 Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 // 31 //
32 // See minidump.h for documentation. 32 // See minidump.h for documentation.
33 // 33 //
34 // Author: Mark Mentovai 34 // Author: Mark Mentovai
35 35
36 #include "google_breakpad/processor/minidump.h" 36 #include "google_breakpad/processor/minidump.h"
37 37
38 #include <assert.h> 38 #include <assert.h>
39 #include <fcntl.h> 39 #include <fcntl.h>
40 #include <stddef.h> 40 #include <stddef.h>
41 #include <stdio.h>
42 #include <string.h> 41 #include <string.h>
43 #include <time.h> 42 #include <time.h>
44 43
45 #ifdef _WIN32 44 #ifdef _WIN32
46 #include <io.h> 45 #include <io.h>
47 #if defined(_MSC_VER) && _MSC_VER < 1900
48 #define snprintf _snprintf
49 #endif
50 #else // _WIN32 46 #else // _WIN32
51 #include <unistd.h> 47 #include <unistd.h>
52 #endif // _WIN32 48 #endif // _WIN32
53 49
54 #include <fstream> 50 #include <fstream>
55 #include <iostream> 51 #include <iostream>
56 #include <limits> 52 #include <limits>
57 #include <map> 53 #include <map>
58 #include <vector> 54 #include <vector>
59 55
60 #include "processor/range_map-inl.h" 56 #include "processor/range_map-inl.h"
61 57
62 #include "common/scoped_ptr.h" 58 #include "common/scoped_ptr.h"
59 #include "common/stdio.h"
63 #include "google_breakpad/processor/dump_context.h" 60 #include "google_breakpad/processor/dump_context.h"
64 #include "processor/basic_code_module.h" 61 #include "processor/basic_code_module.h"
65 #include "processor/basic_code_modules.h" 62 #include "processor/basic_code_modules.h"
66 #include "processor/logging.h" 63 #include "processor/logging.h"
67 64
68 namespace google_breakpad { 65 namespace google_breakpad {
69 66
70 67
71 using std::istream; 68 using std::istream;
72 using std::ifstream; 69 using std::ifstream;
(...skipping 4707 matching lines...) Expand 10 before | Expand all | Expand 10 after
4780 return NULL; 4777 return NULL;
4781 } 4778 }
4782 4779
4783 *stream = new_stream.release(); 4780 *stream = new_stream.release();
4784 info->stream = *stream; 4781 info->stream = *stream;
4785 return *stream; 4782 return *stream;
4786 } 4783 }
4787 4784
4788 4785
4789 } // namespace google_breakpad 4786 } // namespace google_breakpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698