Fix usage of snprintf for MSVC

src/common/stdio.h

-// Copyright (c) 2010 Google Inc.
+// Copyright (c) 2016, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 // copyright notice, this list of conditions and the following disclaimer
 // in the documentation and/or other materials provided with the
 // distribution.
 //     * Neither the name of Google Inc. nor the names of its
 // contributors may be used to endorse or promote products derived from
 // this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// dump_object.cc: A base class for all mini/micro dump object.
+#ifndef GOOGLE_BREAKPAD_COMMON_STDIO_H
+#define GOOGLE_BREAKPAD_COMMON_STDIO_H
 
-#include "google_breakpad/processor/dump_object.h"
+#include <stdio.h>
 
-namespace google_breakpad {
+#if defined(_MSC_VER) && MSC_VER < 1900
+#include <basetsd.h>
 
-DumpObject::DumpObject() : valid_(false) {
-}
+#define snprintf _snprintf

[brucedawson, 2016/01/20 21:29:16]

It's slightly terrifying that we're doing this mapping, since snprintf
guarantees null-termination and _snprintf does not (in the case where the buffer
is too small).

But, this becomes irrelevant to Chromium once we switch to VS 2015 (imminently!)
and the one snprintf usage I saw was safe.

This #define does continue to be a bad idea for breakpad users other than
Chromium who might continue using VS 2013 or earlier. The correct solution is to
write and use an snprintf replacement that guarantees null-termination.

+typedef SSIZE_T ssize_t;
+#endif
 
-}  // namespace google_breakpad
+
+#endif  // GOOGLE_BREAKPAD_COMMON_STDIO_H