Issue 160254: Merge 21612 - Implement mimetype sniffing for extensions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160254: Merge 21612 - Implement mimetype sniffing for extensions.... (Closed)

Created:
11 years, 5 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, willchan no longer on Chromium, Erik does not do reviews, Paul Godavari, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21612 - Implement mimetype sniffing for extensions. abarth: can you review the changes to mime_sniffer.cc? paul: everything else? BUG=13296 TEST=Added unit tests Review URL: http://codereview.chromium.org/159345 TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21814

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -7 lines)			Patch
MM	chrome/browser/download/download_manager.h	View	3 chunks	+5 lines, -0 lines	0 comments	Download
MM	chrome/browser/download/download_manager.cc	View	6 chunks	+7 lines, -2 lines	0 comments	Download
MM	chrome/browser/download/save_package.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/common/extensions/extension.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
MM	chrome/common/extensions/extension.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
MM	chrome/common/extensions/extension_unittest.cc	View	3 chunks	+26 lines, -0 lines	0 comments	Download
MM	net/base/mime_sniffer.cc	View	3 chunks	+43 lines, -1 line	0 comments	Download
MM	net/base/mime_sniffer_unittest.cc	View	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages