Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 160253005: [OSX] IMAGE_GRID macro for NinePartImage. (Closed)

Created:
6 years, 10 months ago by groby-ooo-7-16
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Robert Sesek
Visibility:
Public.

Description

[OSX] IMAGE_GRID macro for NinePartImage. Mirrors Views' IMAGE_GRID macro, reducing boilerplate code. BUG=none R=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -98 lines) Patch
M chrome/browser/ui/cocoa/browser/avatar_label_button.mm View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +5 lines, -23 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm View 1 chunk +1 line, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/search_button_decoration.mm View 1 chunk +7 lines, -31 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm View 1 chunk +1 line, -11 lines 0 comments Download
M ui/base/cocoa/appkit_utils.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
groby-ooo-7-16
6 years, 10 months ago (2014-02-12 03:14:31 UTC) #1
groby-ooo-7-16
-rsesek since OOO avi: PTAL. And if you have a good idea where we could ...
6 years, 10 months ago (2014-02-12 23:38:34 UTC) #2
Avi (use Gerrit)
LGTM I don't know enough about Views to comment on reuse.
6 years, 10 months ago (2014-02-13 16:19:31 UTC) #3
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-13 20:06:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/160253005/1
6 years, 10 months ago (2014-02-13 20:13:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 21:39:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263724
6 years, 10 months ago (2014-02-13 21:39:03 UTC) #7
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-13 22:24:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/160253005/1
6 years, 10 months ago (2014-02-13 22:27:33 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 01:33:40 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=201847
6 years, 10 months ago (2014-02-14 01:33:41 UTC) #11
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-14 01:55:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/160253005/1
6 years, 10 months ago (2014-02-14 01:56:28 UTC) #13
commit-bot: I haz the power
Change committed as 251257
6 years, 10 months ago (2014-02-14 04:21:22 UTC) #14
Robert Sesek
6 years, 10 months ago (2014-02-24 14:02:09 UTC) #15
Message was sent while issue was closed.
ex post facto lgtm

This is way nicer than the array. I can't think of a place where both Cocoa and
Views could share this (and I don't think it deserves its own file). Because the
Cocoa 9-patch drawing function uses AppKit types in the signature, it can't go
into a header that's included by .cc files (like nine_image_painter.h). Oh well,
it's not that much code.

Powered by Google App Engine
This is Rietveld 408576698