Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1602513004: Remove PaintInfo's paintingRoot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase for landing Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 void addPart(LayoutPart*); 215 void addPart(LayoutPart*);
216 void removePart(LayoutPart*); 216 void removePart(LayoutPart*);
217 217
218 void updateWidgetGeometries(); 218 void updateWidgetGeometries();
219 219
220 void addPartToUpdate(LayoutEmbeddedObject&); 220 void addPartToUpdate(LayoutEmbeddedObject&);
221 221
222 void setIsPainting(bool val) const { m_isPainting = val; } 222 void setIsPainting(bool val) const { m_isPainting = val; }
223 bool isPainting() const; 223 bool isPainting() const;
224 224
225 void setNodeToDraw(Node*);
226 Node* nodeToDraw() const { return m_nodeToDraw.get(); }
227
228 Color documentBackgroundColor() const; 225 Color documentBackgroundColor() const;
229 226
230 // Run all needed lifecycle stages. After calling this method, all frames wi ll be in the lifecycle state PaintInvalidationClean. 227 // Run all needed lifecycle stages. After calling this method, all frames wi ll be in the lifecycle state PaintInvalidationClean.
231 // If lifecycle throttling is allowed (see DocumentLifecycle::PreventThrottl ingScope), some frames may skip the lifecycle update 228 // If lifecycle throttling is allowed (see DocumentLifecycle::PreventThrottl ingScope), some frames may skip the lifecycle update
232 // (e.g., based on visibility) and will not end up being PaintInvalidationCl ean. 229 // (e.g., based on visibility) and will not end up being PaintInvalidationCl ean.
233 void updateAllLifecyclePhases(); 230 void updateAllLifecyclePhases();
234 231
235 // Computes the style, layout and compositing lifecycle stages if needed. Af ter calling this method, all frames will be in a lifecycle 232 // Computes the style, layout and compositing lifecycle stages if needed. Af ter calling this method, all frames will be in a lifecycle
236 // state >= CompositingClean, and scrolling has been updated (unless throttl ing is allowed). 233 // state >= CompositingClean, and scrolling has been updated (unless throttl ing is allowed).
237 void updateLifecycleToCompositingCleanPlusScrolling(); 234 void updateLifecycleToCompositingCleanPlusScrolling();
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 IntSize m_lastViewportSize; 792 IntSize m_lastViewportSize;
796 float m_lastZoomFactor; 793 float m_lastZoomFactor;
797 794
798 AtomicString m_mediaType; 795 AtomicString m_mediaType;
799 AtomicString m_mediaTypeWhenNotPrinting; 796 AtomicString m_mediaTypeWhenNotPrinting;
800 797
801 bool m_safeToPropagateScrollToParent; 798 bool m_safeToPropagateScrollToParent;
802 799
803 bool m_isTrackingPaintInvalidations; // Used for testing. 800 bool m_isTrackingPaintInvalidations; // Used for testing.
804 801
805 RefPtrWillBeMember<Node> m_nodeToDraw;
806
807 // TODO(wangxianzhu): Use document cycle state for spv2 and synchronzied pai nting. 802 // TODO(wangxianzhu): Use document cycle state for spv2 and synchronzied pai nting.
808 mutable bool m_isPainting; 803 mutable bool m_isPainting;
809 804
810 unsigned m_visuallyNonEmptyCharacterCount; 805 unsigned m_visuallyNonEmptyCharacterCount;
811 unsigned m_visuallyNonEmptyPixelCount; 806 unsigned m_visuallyNonEmptyPixelCount;
812 bool m_isVisuallyNonEmpty; 807 bool m_isVisuallyNonEmpty;
813 808
814 RefPtrWillBeMember<Node> m_scrollAnchor; 809 RefPtrWillBeMember<Node> m_scrollAnchor;
815 810
816 // layoutObject to hold our custom scroll corner. 811 // layoutObject to hold our custom scroll corner.
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
920 static const unsigned visualPixelThreshold = 32 * 32; 915 static const unsigned visualPixelThreshold = 32 * 32;
921 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 916 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
922 setIsVisuallyNonEmpty(); 917 setIsVisuallyNonEmpty();
923 } 918 }
924 919
925 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 920 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
926 921
927 } // namespace blink 922 } // namespace blink
928 923
929 #endif // FrameView_h 924 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698