Several cleanup items, and one visible change:

Several cleanup items, and one visible change:

* Eliminte the distinction between "item to item padding" and "item to edge
  padding" because the two values are always equal.
* Don't bother supporting "height 0 = use preferred height" in
  location_bar_layout.*, since only one caller uses it at this point and it's
  easier to understand the code by just making it explicit.
* Switch to using a views::Painter for the popup mode background as well,
  instead of explicitly drawing the images.  This will make it easy to switch
  both modes to ninebox painting in the future.
* Try to reorder code in order to declare variables as close to their use as
  possible, and in the order that they're accessed.
* Visible change: Instead of assuming the edit always has 1 px. of "internal
  space", calculate the correct conditions for which that's true.  This results
  in the OmniboxViewViews text moving right by 1 px. in the LTR case.

BUG=231005, 239902
TEST=With "views textfield" on, address bar text moves 1 px. right
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202916

[sky, 2013-05-27 15:30:21]

LGTM

[Peter Kasting, 2013-05-29 18:22:44]

Committed patchset #2 manually as r202916 (presubmit successful).