third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html - Issue 1602443006: Set the correct buttons for long press action

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html

Issue 1602443006: Set the correct buttons for long press action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute-expected.txt » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html b/third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html

index e4ec117cb340e6155eb5574e0a298dcfbc38b456..cc8ad65bc1bfbe51e752dad9836bc6862603a9ca 100644

--- a/third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html

+++ b/third_party/WebKit/LayoutTests/fast/events/mouse-event-buttons-attribute.html

@@ -38,10 +38,7 @@ var testSet = [

{ initialButtons: [], action: doubleTapAction },

{ initialButtons: [], action: tapAction },

{ initialButtons: [], action: longPressAction, showContextMenuOnMouseUp: false },

- //TODO(nzolghadr): crbug.com/576281 "buttons" field should be set in mousedown and contextmenu events

{ initialButtons: [], action: longPressAction, showContextMenuOnMouseUp: true },

{ initialButtons: [], action: longTapAction, showContextMenuOnMouseUp: false },

{ initialButtons: [], action: longTapAction, showContextMenuOnMouseUp: true },

{ initialButtons: [], action: dragDropAction },