Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 1602443005: OpenH264 gyp file updated. (Closed)

Created:
4 years, 11 months ago by hbos_chromium
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

OpenH264 gyp file updated. -Wno-unused-function necessary when building win/clang/release from webrtc repo. BUG=468365 NOTRY=True Committed: https://crrev.com/b2cdbda47fd2be20216e7c53bce4ecaf1331bc37 Cr-Commit-Position: refs/heads/master@{#370087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/openh264/openh264.gyp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hbos_chromium
Please take a quick look, kjellander. I only tested webrtc/win/clang/debug locally, not webrtc/win/clang/release - pssh, ...
4 years, 11 months ago (2016-01-19 08:24:23 UTC) #3
kjellander_chromium
lgtm
4 years, 11 months ago (2016-01-19 08:43:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602443005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602443005/1
4 years, 11 months ago (2016-01-19 08:50:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 08:56:37 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 08:58:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2cdbda47fd2be20216e7c53bce4ecaf1331bc37
Cr-Commit-Position: refs/heads/master@{#370087}

Powered by Google App Engine
This is Rietveld 408576698