Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1602423002: Fix non-optimized instanceof check after removal of signature classes. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 489 matching lines...) Expand 10 before | Expand all | Expand 10 after
500 SubtypeTestCache::ZoneHandle(zone(), 500 SubtypeTestCache::ZoneHandle(zone(),
501 GenerateCallSubtypeTestStub(kTestTypeThreeArgs, 501 GenerateCallSubtypeTestStub(kTestTypeThreeArgs,
502 kInstanceReg, 502 kInstanceReg,
503 kTypeArgumentsReg, 503 kTypeArgumentsReg,
504 kTempReg, 504 kTempReg,
505 is_instance_lbl, 505 is_instance_lbl,
506 is_not_instance_lbl)); 506 is_not_instance_lbl));
507 __ Bind(&fall_through); 507 __ Bind(&fall_through);
508 return type_test_cache.raw(); 508 return type_test_cache.raw();
509 } 509 }
510 if (type.IsType()) { 510 if (type.IsType() || type.IsFunctionType()) {
511 const Register kInstanceReg = R0; 511 const Register kInstanceReg = R0;
512 const Register kTypeArgumentsReg = R1; 512 const Register kTypeArgumentsReg = R1;
513 __ tst(kInstanceReg, Operand(kSmiTagMask)); // Is instance Smi? 513 __ tst(kInstanceReg, Operand(kSmiTagMask)); // Is instance Smi?
514 __ b(is_not_instance_lbl, EQ); 514 __ b(is_not_instance_lbl, EQ);
515 __ ldr(kTypeArgumentsReg, Address(SP, 0)); // Instantiator type args. 515 __ ldr(kTypeArgumentsReg, Address(SP, 0)); // Instantiator type args.
516 // Uninstantiated type class is known at compile time, but the type 516 // Uninstantiated type class is known at compile time, but the type
517 // arguments are determined at runtime by the instantiator. 517 // arguments are determined at runtime by the instantiator.
518 const Register kTempReg = kNoRegister; 518 const Register kTempReg = kNoRegister;
519 return GenerateCallSubtypeTestStub(kTestTypeThreeArgs, 519 return GenerateCallSubtypeTestStub(kTestTypeThreeArgs,
520 kInstanceReg, 520 kInstanceReg,
(...skipping 1413 matching lines...) Expand 10 before | Expand all | Expand 10 after
1934 DRegister dreg = EvenDRegisterOf(reg); 1934 DRegister dreg = EvenDRegisterOf(reg);
1935 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1935 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1936 } 1936 }
1937 1937
1938 1938
1939 #undef __ 1939 #undef __
1940 1940
1941 } // namespace dart 1941 } // namespace dart
1942 1942
1943 #endif // defined TARGET_ARCH_ARM 1943 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698