Construct a minimal blink library in-place

Construct a minimal blink library in-place

This defines a library with a minimal set of WebKit symbols that can be linked
into locations that need to use pieces of the WebKit API without needing the
whole thing.

BUG=237267
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152486

[jamesr, 2013-06-07 01:22:29]

Same as https://codereview.chromium.org/15079005/, but this time in-place. 
Slicing up directories in gyp seems dodgy to me but there aren't a lot of clean
options here.

[jamesr, 2013-06-10 21:59:17]

friendly ping, Darin

[darin (slow to review), 2013-06-10 22:05:38]

This makes me a bit sad, but LGTM.  I hope we can eliminate this shortly.

https://codereview.chromium.org/16024011/diff/4001/Source/bindings/bindings.gyp
File Source/bindings/bindings.gyp (right):

https://codereview.chromium.org/16024011/diff/4001/Source/bindings/bindings.g...
Source/bindings/bindings.gyp:65: 'INSIDE_WEBKIT',
I guess you probably considered names for this macro like INSIDE_BLINK?  Or,
BLINK_INSIDES, BLINK_INNARDS,...? :-/

https://codereview.chromium.org/16024011/diff/4001/public/blink.gyp
File public/blink.gyp (right):

https://codereview.chromium.org/16024011/diff/4001/public/blink.gyp#newcode48
public/blink.gyp:48: 'target_name': 'blink_minimal',
You might want to add some comments explaining what this library is for, etc.  I
think--I hope--we can also say that it is a temporary solution :)

[jamesr, 2013-06-10 22:26:13]

On 2013/06/10 22:05:38, darin wrote:
> This makes me a bit sad, but LGTM.  I hope we can eliminate this shortly.
> 
>
https://codereview.chromium.org/16024011/diff/4001/Source/bindings/bindings.gyp
> File Source/bindings/bindings.gyp (right):
> 
>
https://codereview.chromium.org/16024011/diff/4001/Source/bindings/bindings.g...
> Source/bindings/bindings.gyp:65: 'INSIDE_WEBKIT',
> I guess you probably considered names for this macro like INSIDE_BLINK?  Or,
> BLINK_INSIDES, BLINK_INNARDS,...? :-/

INSIDE_BLINK is a bit better but of these suffer from inconsistency with
WEBKIT_IMPLEMENTATION.  I think that's a little too big to rename in this patch.

> 
> https://codereview.chromium.org/16024011/diff/4001/public/blink.gyp
> File public/blink.gyp (right):
> 
> https://codereview.chromium.org/16024011/diff/4001/public/blink.gyp#newcode48
> public/blink.gyp:48: 'target_name': 'blink_minimal',
> You might want to add some comments explaining what this library is for, etc. 
I
> think--I hope--we can also say that it is a temporary solution :)

I'll add a comment with a link to a bug.

[commit-bot: I haz the power, 2013-06-11 19:47:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/16024011/13001

[jochen (gone - plz use gerrit), 2013-06-11 19:52:21]

lgtm

[commit-bot: I haz the power, 2013-06-11 20:39:51]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[jamesr, 2013-06-11 20:53:45]

Some code landed chromium-side that depends on
Source/WebKit/chromium/WebKit.gyp:webkit instead of public/blink.gyp:blink -
will have to patch on the chromium side then land this.

[jamesr, 2013-06-12 04:53:43]

Should be good to go as of r205719

[commit-bot: I haz the power, 2013-06-12 04:54:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/16024011/13001

[commit-bot: I haz the power, 2013-06-12 05:25:47]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-15 00:03:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/16024011/43001

[commit-bot: I haz the power, 2013-06-15 02:21:17]

Change committed as 152486