Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1602393002: Revert of Have gn gen assert that the output directory does not have GYP artifacts (Closed)

Created:
4 years, 11 months ago by mdjones
Modified:
4 years, 11 months ago
Reviewers:
brettw, jbudorick, agrieve
CC:
chromium-reviews, Primiano Tucci (use gerrit), Yaron, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Have gn gen assert that the output directory does not have GYP artifacts (patchset #2 id:20001 of https://codereview.chromium.org/1601893002/ ) Reason for revert: arm-builder-rel, arm64-builder-rel, gn-release-builder-l consistently fail the assertion added in this change. Original issue's description: > Have gn gen assert that the output directory does not have GYP artifacts > > This can often lead to compile errors. > > BUG=578862 > > Committed: https://crrev.com/5915049689627393a3eb8f531f3a361eedcfbce0 > Cr-Commit-Position: refs/heads/master@{#370210} TBR=brettw@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=578862 Committed: https://crrev.com/caf664a996be25ec5f567f183dd897de4abff952 Cr-Commit-Position: refs/heads/master@{#370288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mdjones
Created Revert of Have gn gen assert that the output directory does not have GYP ...
4 years, 11 months ago (2016-01-20 02:35:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602393002/1
4 years, 11 months ago (2016-01-20 02:39:21 UTC) #2
jbudorick
On 2016/01/20 02:42:07, jbudorick wrote: > The CQ bit was unchecked by mailto:jbudorick@chromium.org pulled out ...
4 years, 11 months ago (2016-01-20 02:42:39 UTC) #4
jbudorick
On 2016/01/20 02:42:39, jbudorick wrote: > On 2016/01/20 02:42:07, jbudorick wrote: > > The CQ ...
4 years, 11 months ago (2016-01-20 02:46:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602393002/1
4 years, 11 months ago (2016-01-20 02:49:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 02:51:56 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/caf664a996be25ec5f567f183dd897de4abff952 Cr-Commit-Position: refs/heads/master@{#370288}
4 years, 11 months ago (2016-01-20 02:53:27 UTC) #11
agrieve
4 years, 10 months ago (2016-02-16 15:37:17 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1702013002/ by agrieve@chromium.org.

The reason for reverting is: Attempting reland (no changes).

Powered by Google App Engine
This is Rietveld 408576698