[Chromecast] Add volume step interval getter to AvSettings.

[Chromecast] Add volume step interval getter to AvSettings.

OEM partners may wish to have more control over reported volume
intervals, so expose API that allows shared library to either
opt-in and set intervals or opt-out and use default values.

BUG=internal b/24333496
TEST=none

Committed: https://crrev.com/ff685ebcc762c7d0f4ade6ea29c6099b047c12da
Cr-Commit-Position: refs/heads/master@{#370758}

[maclellant, 2016-01-20 22:44:18]

maclellant@chromium.org changed reviewers:
+ byungchul@chromium.org, gfhuang@chromium.org, gnikita@google.com,
halliwell@chromium.org, maclellant@chromium.org

[gfhuang, 2016-01-20 22:48:22]

https://codereview.chromium.org/1602323003/diff/1/chromecast/public/avsettings.h
File chromecast/public/avsettings.h (right):

https://codereview.chromium.org/1602323003/diff/1/chromecast/public/avsetting...
chromecast/public/avsettings.h:109: AUDIO_VOLUME_STEP_INTERVAL_CHANGED = 6,
I think you should just give up ordering and use next one, i.e. 7

it's general good practice not to change existing enums

https://codereview.chromium.org/1602323003/diff/1/chromecast/public/avsetting...
chromecast/public/avsettings.h:191: //  - MASTER_VOLUME (5%)
"5%" -> "5%, i.e. 0.05" to make it more clear in the range of [0.0, 1.0]

[byungchul, 2016-01-21 01:02:18]

lgtm

[halliwell, 2016-01-21 14:18:47]

lgtm % nit

https://codereview.chromium.org/1602323003/diff/20001/chromecast/public/avset...
File chromecast/public/avsettings.h (right):

https://codereview.chromium.org/1602323003/diff/20001/chromecast/public/avset...
chromecast/public/avsettings.h:185: // Retrieves the volume step interval as
percentage in range [0.0, 1.0] that
nit: remove 'as percentage', contradicts range [0,1]

[gfhuang, 2016-01-21 19:23:34]

lgtm

[maclellant, 2016-01-21 19:24:25]

The CQ bit was checked by maclellant@chromium.org

[maclellant, 2016-01-21 19:24:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
byungchul@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1602323003/#ps40001
(title: "Update API comment")

[commit-bot: I haz the power, 2016-01-21 19:24:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602323003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602323003/40001

[commit-bot: I haz the power, 2016-01-21 19:50:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-21 19:51:49]

Description was changed from

==========
[Chromecast] Add volume step interval getter to AvSettings.

OEM partners may wish to have more control over reported volume
intervals, so expose API that allows shared library to either
opt-in and set intervals or opt-out and use default values.

BUG=internal b/24333496
TEST=none
==========

to

==========
[Chromecast] Add volume step interval getter to AvSettings.

OEM partners may wish to have more control over reported volume
intervals, so expose API that allows shared library to either
opt-in and set intervals or opt-out and use default values.

BUG=internal b/24333496
TEST=none

Committed: https://crrev.com/ff685ebcc762c7d0f4ade6ea29c6099b047c12da
Cr-Commit-Position: refs/heads/master@{#370758}
==========

[commit-bot: I haz the power, 2016-01-21 19:51:50]

Patchset 3 (id:??) landed as
https://crrev.com/ff685ebcc762c7d0f4ade6ea29c6099b047c12da
Cr-Commit-Position: refs/heads/master@{#370758}