ios/consumer/public/base/util.h - Issue 16023013: Introduce the iOS consumer API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/consumer/public/base/util.h

Issue 16023013: Introduce the iOS consumer API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Response to reviews Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CONSUME_PUBLIC_BASE_UTIL_H_

	6 #define IOS_CONSUME_PUBLIC_BASE_UTIL_H_

	7

	8 namespace ios {

	9 namespace base {
	darin (slow to review) 2013/05/28 21:00:09 I recommend avoiding nested namespaces. I especia I recommend avoiding nested namespaces. I especially recommend avoiding using "base" as a nested namespace. Having to type ::base to access code in src/base/ kind of sucks. Also, it seems a bit humorous that the implementation of ::ios::base code involves calling methods defined in ::base::ios ;-) How about just using ios as the namespace or ios_consumer?
	10

	11 // Returns whether the operating system is iOS 6 or later.

	12 bool IsRunningOnIOS6OrLater();

	13

	14 // Returns whether the operating system is at the given version or later.

	15 bool IsRunningOnOrLater(int major, int minor, int bug_fix);

	16

	17 } // namespace base

	18 } // namespace ios

	19

	20 #endif // IOS_CONSUME_PUBLIC_BASE_UTIL_H_

OLD	NEW

« no previous file with comments | « ios/consumer/public/DEPS ('k') | no next file » | no next file with comments »