Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/background/background_contents_service.cc

Issue 16023005: Add HasClickedListener to the notification delegate in background_content_service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/background/background_contents_service.h" 5 #include "chrome/browser/background/background_contents_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 } else { 97 } else {
98 extensions::ExtensionSystem::Get(profile_)->extension_service()-> 98 extensions::ExtensionSystem::Get(profile_)->extension_service()->
99 ReloadExtension(extension_id_); 99 ReloadExtension(extension_id_);
100 } 100 }
101 101
102 // Closing the balloon here should be OK, but it causes a crash on Mac 102 // Closing the balloon here should be OK, but it causes a crash on Mac
103 // http://crbug.com/78167 103 // http://crbug.com/78167
104 ScheduleCloseBalloon(extension_id_); 104 ScheduleCloseBalloon(extension_id_);
105 } 105 }
106 106
107 virtual bool HasClickedListener() OVERRIDE { return true; }
Andrew T Wilson (Slow) 2013/05/27 12:36:50 Please add a comment describing why this is requir
Jun Mukai 2013/05/27 19:10:28 I may miss your point. Those methods are inherited
108
107 virtual std::string id() const OVERRIDE { 109 virtual std::string id() const OVERRIDE {
108 return kNotificationPrefix + extension_id_; 110 return kNotificationPrefix + extension_id_;
109 } 111 }
110 112
111 virtual content::RenderViewHost* GetRenderViewHost() const OVERRIDE { 113 virtual content::RenderViewHost* GetRenderViewHost() const OVERRIDE {
112 return NULL; 114 return NULL;
113 } 115 }
114 116
115 private: 117 private:
116 virtual ~CrashNotificationDelegate() {} 118 virtual ~CrashNotificationDelegate() {}
(...skipping 563 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 bool user_gesture, 682 bool user_gesture,
681 bool* was_blocked) { 683 bool* was_blocked) {
682 Browser* browser = chrome::FindLastActiveWithProfile( 684 Browser* browser = chrome::FindLastActiveWithProfile(
683 Profile::FromBrowserContext(new_contents->GetBrowserContext()), 685 Profile::FromBrowserContext(new_contents->GetBrowserContext()),
684 chrome::GetActiveDesktop()); 686 chrome::GetActiveDesktop());
685 if (browser) { 687 if (browser) {
686 chrome::AddWebContents(browser, NULL, new_contents, disposition, 688 chrome::AddWebContents(browser, NULL, new_contents, disposition,
687 initial_pos, user_gesture, was_blocked); 689 initial_pos, user_gesture, was_blocked);
688 } 690 }
689 } 691 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698