Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1602293002: base: Remove SYSLOG* macros from logging.h. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove SYSLOG* macros from logging.h. They are unused and are equivalent to the LOG* macros anyhow. Committed: https://crrev.com/d09a8b60ddda06ab547146495b3f012b62dc3793 Cr-Commit-Position: refs/heads/master@{#370295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M base/logging.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbroman
WDYT (assuming trybots agree when they stop being broken)
4 years, 11 months ago (2016-01-20 00:23:27 UTC) #3
danakj
LGTM
4 years, 11 months ago (2016-01-20 00:26:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602293002/1
4 years, 11 months ago (2016-01-20 01:09:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 04:08:03 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 04:09:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d09a8b60ddda06ab547146495b3f012b62dc3793
Cr-Commit-Position: refs/heads/master@{#370295}

Powered by Google App Engine
This is Rietveld 408576698