Merge 21531 - Fix a race condition where rapid back/forward clicks could clos...

Merge 21531 - Fix a race condition where rapid back/forward clicks could close a tab

This can be triggered when you're on the new tab page, going to *two* other
sites, then rapidly hitting back and forward randomly. If a crosssite
transition was canceled before the original page responds with an "OK to close
me" message, it will mistakenly categorize the close as not just for the
RenderView (correspondong to one side of the crosssite transition) but for the
entire tab.

This change adds an explicit parameter on the messages indicating whether it's
for interstials or for the tab so we don't have to rely on the request still
being active.

This also adds the "requesting process + route" in addition to the
"new process + request" so we can be more clear about sending the messages to
the correct place. The previous patch conbimed these in a confusing way.

BUG=16246
TEST=none
Review URL: http://codereview.chromium.org/159255

TBR=brettw@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21765

[brettw, 2009-07-28 02:47:44]

LGTM

On Mon, Jul 27, 2009 at 5:35 PM, <laforge@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Merge 21531 - Fix a race condition where rapid back/forward clicks could
> close a tab
>
> This can be triggered when you're on the new tab page, going to *two*
> other
> sites, then rapidly hitting back and forward randomly. If a crosssite
> transition was canceled before the original page responds with an "OK to
> close
> me" message, it will mistakenly categorize the close as not just for the
> RenderView (correspondong to one side of the crosssite transition) but
> for the
> entire tab.
>
> This change adds an explicit parameter on the messages indicating
> whether it's
> for interstials or for the tab so we don't have to rely on the request
> still
> being active.
>
> This also adds the "requesting process + route" in addition to the
> "new process + request" so we can be more clear about sending the
> messages to
> the correct place. The previous patch conbimed these in a confusing way.
>
> BUG=3D16246
> TEST=3Dnone
> Review URL: http://codereview.chromium.org/159255
>
> TBR=3Dbrettw@chromium.org
>
>
> Please review this at http://codereview.chromium.org/160229
>
> SVN Base: svn://chrome-svn/chrome/branches/195/src/
>
> Affected files:
> =A0MM =A0 =A0chrome/browser/browser.cc
> =A0MM =A0 =A0chrome/browser/renderer_host/browser_render_process_host.h
> =A0MM =A0 =A0chrome/browser/renderer_host/browser_render_process_host.cc
> =A0MM =A0 =A0chrome/browser/renderer_host/mock_render_process_host.h
> =A0MM =A0 =A0chrome/browser/renderer_host/mock_render_process_host.cc
> =A0MM =A0 =A0chrome/browser/renderer_host/render_process_host.h
> =A0MM =A0 =A0chrome/browser/renderer_host/render_view_host.h
> =A0MM =A0 =A0chrome/browser/renderer_host/render_view_host.cc
> =A0MM =A0 =A0chrome/browser/renderer_host/render_widget_helper.h
> =A0MM =A0 =A0chrome/browser/renderer_host/render_widget_helper.cc
> =A0MM =A0 =A0chrome/browser/renderer_host/resource_dispatcher_host.h
> =A0MM =A0 =A0chrome/browser/renderer_host/resource_dispatcher_host.cc
> =A0MM =A0 =A0chrome/browser/tab_contents/render_view_host_manager.cc
> =A0MM =A0 =A0chrome/common/render_messages.h
> =A0MM =A0 =A0chrome/common/render_messages_internal.h
> =A0MM =A0 =A0chrome/renderer/render_view.h
> =A0MM =A0 =A0chrome/renderer/render_view.cc
>
>
>