net/cookies/cookie_monster.cc - Issue 1602283002: Convert some raw CanonicalCookie ptrs to scoped_ptr<CanonicalCookie>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/cookie_monster.cc

Issue 1602283002: Convert some raw CanonicalCookie ptrs to scoped_ptr<CanonicalCookie>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix missed CanonicalCookie::Create() callsite in ios/net/cookies/cookie_store_ios_unittest.mm Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/cookie_monster.cc

diff --git a/net/cookies/cookie_monster.cc b/net/cookies/cookie_monster.cc

index 15e4f7ee8e15f3514a2600bec9d926654c449eae..76f9d93506341ae883d669544d9416c9817051f3 100644

--- a/net/cookies/cookie_monster.cc

+++ b/net/cookies/cookie_monster.cc

@@ -1153,8 +1153,7 @@ bool CookieMonster::SetCookieWithDetails(const GURL& url,

Time creation_time = CurrentTime();

last_time_seen_ = creation_time;

- scoped_ptr<CanonicalCookie> cc;

- cc.reset(CanonicalCookie::Create(

+ scoped_ptr<CanonicalCookie> cc(CanonicalCookie::Create(

url, name, value, domain, path, creation_time, expiration_time, secure,

http_only, first_party_only, enforce_strict_secure, priority));

« no previous file with comments | « net/cookies/canonical_cookie_unittest.cc ('k') | net/cookies/cookie_monster_unittest.cc » ('j') | no next file with comments »