Issue 1602263002: Fix summarization of trailing `dynamic` type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1602263002: Fix summarization of trailing `dynamic` type arguments. (Closed)

Created:
4 years, 11 months ago by Paul Berry

Modified:
4 years, 11 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix summarization of trailing `dynamic` type arguments. Serialization code now matches the comments in the IDL, which say that trailing `dynamic` type arguments (e.g. `Map<int, dynamic>`) are omitted from the summary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/cbe4248f4ee4406c1a071df3661b19fa6c5eca75

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -12 lines)			Patch
M	pkg/analyzer/lib/src/summary/summarize_ast.dart	View	2 chunks	+16 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	1 chunk	+16 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/resynthesize_test.dart	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_test.dart	View	2 chunks	+36 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 11 months ago (2016-01-19 21:34:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cbe4248f4ee4406c1a071df3661b19fa6c5eca75 (presubmit successful).