Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Issue 1602203007: [UseZoomForDSF] Convert draggable region to Window coordinates (Closed)

Created:
4 years, 11 months ago by oshima
Modified:
4 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UseZoomForDSF] Convert draggable region from Viewport to Window coordinates These coordinates are currently the same but will differ when use-zoom-for-dsf is enabled. (See bug for discussion and design doc) BUG=485650 Committed: https://crrev.com/778499c7d9528f64ff7b4837441f0a86670b13ce Cr-Commit-Position: refs/heads/master@{#370643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M extensions/renderer/extension_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
oshima
4 years, 11 months ago (2016-01-21 00:36:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602203007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602203007/1
4 years, 11 months ago (2016-01-21 00:37:49 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 03:09:43 UTC) #9
benwells
lgtm
4 years, 11 months ago (2016-01-21 06:49:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602203007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602203007/1
4 years, 11 months ago (2016-01-21 07:06:46 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 07:11:57 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 07:13:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/778499c7d9528f64ff7b4837441f0a86670b13ce
Cr-Commit-Position: refs/heads/master@{#370643}

Powered by Google App Engine
This is Rietveld 408576698