Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1602203005: Add use counter for preload link headers (Closed)

Created:
4 years, 11 months ago by Yoav Weiss
Modified:
4 years, 11 months ago
Reviewers:
Nate Chapin, Mike West
CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counter for preload link headers When adding use counters for link headers, preload was left out. This CL fixes that historical mistake. BUG=471199 Committed: https://crrev.com/0661feafc9a84f03b04dd3719b8aaa255dfaec63 Cr-Commit-Position: refs/heads/master@{#370666}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 2 4 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Yoav Weiss
4 years, 11 months ago (2016-01-19 21:07:33 UTC) #2
Nate Chapin
lgtm
4 years, 11 months ago (2016-01-20 18:52:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602203005/20001
4 years, 11 months ago (2016-01-20 21:16:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/168819)
4 years, 11 months ago (2016-01-20 22:07:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602203005/20001
4 years, 11 months ago (2016-01-20 23:00:12 UTC) #12
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
4 years, 11 months ago (2016-01-21 00:08:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602203005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602203005/40001
4 years, 11 months ago (2016-01-21 10:03:15 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-21 11:04:55 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 11:05:57 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0661feafc9a84f03b04dd3719b8aaa255dfaec63
Cr-Commit-Position: refs/heads/master@{#370666}

Powered by Google App Engine
This is Rietveld 408576698