pkg/analyzer/tool/summary/idl.dart - Issue 1602203004: Serialize constant initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/tool/summary/idl.dart

Issue 1602203004: Serialize constant initializers. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/tool/summary/idl.dart

diff --git a/pkg/analyzer/tool/summary/idl.dart b/pkg/analyzer/tool/summary/idl.dart

index 42ee3f217f1270ce7f94d90269ecc69d2bbb7d24..8907058adc7a78854fa778ce67e6e3649e8e77e9 100644

--- a/pkg/analyzer/tool/summary/idl.dart

+++ b/pkg/analyzer/tool/summary/idl.dart

@@ -456,7 +456,8 @@ enum UnlinkedConstOperation {

concatenate,

/**

- * Pop the top value from the stack, which should be a string, convert it to

+ * Pop the top n values from the stack (where n is obtained from

Paul Berry 2016/01/19 20:02:10 See my comments at summarize_elements.dart line 11

scheglov 2016/01/19 20:59:28 Done.

+ * [UnlinkedConst.ints]), which should be strings, convert them to

* a symbol, and push it back onto the stack.

makeSymbol,