Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/browser_process_platform_part_aurawin.cc

Issue 16022003: Base for Ash browser_tests on Win8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Do not use SetUp/TearDownTestCase() Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_process_platform_part_aurawin.h" 5 #include "chrome/browser/browser_process_platform_part_aurawin.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/process_util.h" 9 #include "base/process_util.h"
10 #include "base/win/windows_version.h" 10 #include "base/win/windows_version.h"
11 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
12 #include "chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h " 12 #include "chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.h "
13 #include "chrome/common/chrome_switches.h" 13 #include "chrome/common/chrome_switches.h"
14 14
15 BrowserProcessPlatformPart::BrowserProcessPlatformPart() { 15 BrowserProcessPlatformPart::BrowserProcessPlatformPart() {
16 } 16 }
17 17
18 BrowserProcessPlatformPart::~BrowserProcessPlatformPart() { 18 BrowserProcessPlatformPart::~BrowserProcessPlatformPart() {
19 } 19 }
20 20
21 void BrowserProcessPlatformPart::OnMetroViewerProcessTerminated() { 21 void BrowserProcessPlatformPart::OnMetroViewerProcessTerminated() {
22 metro_viewer_process_host_.reset(NULL); 22 metro_viewer_process_host_.reset(NULL);
23 } 23 }
24 24
25 void BrowserProcessPlatformPart::PlatformSpecificCommandLineProcessing( 25 void BrowserProcessPlatformPart::PlatformSpecificCommandLineProcessing(
26 const CommandLine& command_line) { 26 const CommandLine& command_line) {
27 if (base::win::GetVersion() >= base::win::VERSION_WIN8 && 27 // Check for Windows 8 specific commandlines requesting that this process
28 command_line.HasSwitch(switches::kViewerConnect) && 28 // either connect to an existing viewer or launch a new viewer and
29 !metro_viewer_process_host_.get()) { 29 // synchronously wait for it to connect.
30 // Create a host to connect to the Metro viewer process over IPC. 30 if (base::win::GetVersion() >= base::win::VERSION_WIN8) {
31 metro_viewer_process_host_.reset(new ChromeMetroViewerProcessHost()); 31 bool launch = command_line.HasSwitch(switches::kViewerLaunchViaAppId);
32 bool connect = (launch ||
33 (command_line.HasSwitch(switches::kViewerConnect) &&
34 !metro_viewer_process_host_.get()));
35 if (connect) {
36 // Create a host to connect to the Metro viewer process over IPC.
37 metro_viewer_process_host_.reset(new ChromeMetroViewerProcessHost());
38 if (launch) {
39 CHECK(metro_viewer_process_host_->LaunchViewerAndWaitForConnection(
40 command_line.GetSwitchValueNative(
41 switches::kViewerLaunchViaAppId)));
42 }
43 }
32 } 44 }
33 } 45 }
34 46
35 void BrowserProcessPlatformPart::AttemptExit() { 47 void BrowserProcessPlatformPart::AttemptExit() {
36 // On WinAura, the regular exit path is fine except on Win8+, where Ash might 48 // On WinAura, the regular exit path is fine except on Win8+, where Ash might
37 // be active in Metro and won't go away even if all browsers are closed. The 49 // be active in Metro and won't go away even if all browsers are closed. The
38 // viewer process, whose host holds a reference to g_browser_process, needs to 50 // viewer process, whose host holds a reference to g_browser_process, needs to
39 // be killed as well. 51 // be killed as well.
40 BrowserProcessPlatformPartBase::AttemptExit(); 52 BrowserProcessPlatformPartBase::AttemptExit();
41 53
42 if (base::win::GetVersion() >= base::win::VERSION_WIN8 && 54 if (base::win::GetVersion() >= base::win::VERSION_WIN8 &&
43 metro_viewer_process_host_) { 55 metro_viewer_process_host_) {
44 base::ProcessId viewer_id = 56 base::ProcessId viewer_id =
45 metro_viewer_process_host_->GetViewerProcessId(); 57 metro_viewer_process_host_->GetViewerProcessId();
46 if (viewer_id == base::kNullProcessId) 58 if (viewer_id == base::kNullProcessId)
47 return; 59 return;
48 // The viewer doesn't hold any state so it is fine to kill it before it 60 // The viewer doesn't hold any state so it is fine to kill it before it
49 // cleanly exits. This will trigger MetroViewerProcessHost::OnChannelError() 61 // cleanly exits. This will trigger MetroViewerProcessHost::OnChannelError()
50 // which will cleanup references to g_browser_process. 62 // which will cleanup references to g_browser_process.
51 bool success = base::KillProcessById(viewer_id, 0, true); 63 bool success = base::KillProcessById(viewer_id, 0, true);
52 DCHECK(success); 64 DCHECK(success);
53 } 65 }
54 } 66 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698