Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4207)

Unified Diff: chrome/browser/views/options/general_page_view.h

Issue 160218: Fix running default browser check/setting in UI thread on Linux.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/general_page_view.h
===================================================================
--- chrome/browser/views/options/general_page_view.h (revision 21781)
+++ chrome/browser/views/options/general_page_view.h (working copy)
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_VIEWS_OPTIONS_GENERAL_PAGE_VIEW_H_
#define CHROME_BROWSER_VIEWS_OPTIONS_GENERAL_PAGE_VIEW_H_
+#include "chrome/browser/shell_integration.h"
#include "chrome/browser/views/options/options_page_view.h"
#include "chrome/browser/views/shelf_item_dialog.h"
#include "chrome/common/pref_member.h"
@@ -35,7 +36,8 @@
public views::ButtonListener,
public views::Textfield::Controller,
public ShelfItemDialogDelegate,
- public views::TableViewObserver {
+ public views::TableViewObserver,
+ public ShellIntegration::DefaultBrowserObserver {
public:
explicit GeneralPageView(Profile* profile);
virtual ~GeneralPageView();
@@ -64,14 +66,9 @@
virtual void Layout();
private:
- // The current default browser UI state
- enum DefaultBrowserUIState {
- STATE_PROCESSING,
- STATE_DEFAULT,
- STATE_NOT_DEFAULT
- };
+ // ShellIntegration::DefaultBrowserObserver implementation:
// Updates the UI state to reflect the current default browser state.
- void SetDefaultBrowserUIState(DefaultBrowserUIState state);
+ virtual void SetDefaultBrowserUIState(ShellIntegration::DefaultBrowserUIState state);
// Init all the dialog controls
void InitStartupGroup();
@@ -151,9 +148,7 @@
views::NativeButton* default_browser_use_as_default_button_;
// The helper object that performs default browser set/check tasks.
- class DefaultBrowserWorker;
- friend DefaultBrowserWorker;
- scoped_refptr<DefaultBrowserWorker> default_browser_worker_;
+ scoped_refptr<ShellIntegration::DefaultBrowserWorker> default_browser_worker_;
DISALLOW_COPY_AND_ASSIGN(GeneralPageView);
};
« no previous file with comments | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698