Fix running default browser check/setting in UI thread on Linux....

Fix running default browser check/setting in UI thread on Linux.

Rename shell_integration.cc to shell_integration_win.cc, so
shell_integration.cc can be used for cross-platform stuff.

Move DefaultBrowserWorker from GeneralPageView to ShellIntegration.

BUG=17179
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21794

[Evan Stade, 2009-07-28 00:40:37]

LGTM with comments

http://codereview.chromium.org/160218/diff/1019/1024
File chrome/browser/gtk/options/general_page_gtk.cc (right):

http://codereview.chromium.org/160218/diff/1019/1024#newcode61
Line 61: ALLOW_THIS_IN_INITIALIZER_LIST(
ALLOW_THIS_IN_INITIALIZER_LIST is windows-only

http://codereview.chromium.org/160218/diff/1019/1024#newcode346
Line 346: default_browser_status_label_ = gtk_label_new(NULL);
Should probably have some text here for "Checking if browser is default..." and
the button should be insensitive. (Since the strings are frozen you can put a
TODO for the first.)

[mattm, 2009-07-28 01:08:13]

http://codereview.chromium.org/160218/diff/1019/1024
File chrome/browser/gtk/options/general_page_gtk.cc (right):

http://codereview.chromium.org/160218/diff/1019/1024#newcode61
Line 61: ALLOW_THIS_IN_INITIALIZER_LIST(
On 2009/07/28 00:40:39, Evan Stade wrote:
> ALLOW_THIS_IN_INITIALIZER_LIST is windows-only

Done.

http://codereview.chromium.org/160218/diff/1019/1024#newcode346
Line 346: default_browser_status_label_ = gtk_label_new(NULL);
On 2009/07/28 00:40:39, Evan Stade wrote:
> Should probably have some text here for "Checking if browser is default..."
and
> the button should be insensitive. (Since the strings are frozen you can put a
> TODO for the first.)

StartCheckDefaultBrowser calls SetDefaultBrowserUIState(STATE_PROCESSING) which
does make the button insensitive, I'll add a TODO for the string

[Evan Stade, 2009-07-28 01:11:34]

lgtm

http://codereview.chromium.org/160218/diff/1019/1024
File chrome/browser/gtk/options/general_page_gtk.cc (right):

http://codereview.chromium.org/160218/diff/1019/1024#newcode346
Line 346: default_browser_status_label_ = gtk_label_new(NULL);
On 2009/07/28 01:08:13, mattm wrote:
> On 2009/07/28 00:40:39, Evan Stade wrote:
> > Should probably have some text here for "Checking if browser is default..."
> and
> > the button should be insensitive. (Since the strings are frozen you can put
a
> > TODO for the first.)
> 
> StartCheckDefaultBrowser calls SetDefaultBrowserUIState(STATE_PROCESSING)
which
> does make the button insensitive, I'll add a TODO for the string

Ah I see. Thanks for explanation.