Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1602153002: fix circular dashing (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix circular dashing Path measure cannot use the same code approach for quadratics and cubics. Subdividing cubics repeatedly does not result in subdivided t values, e.g. a quarter circle cubic divided in half twice does not have a t value equivalent to 1/4. Instead, always compute the cubic segment from a pair of t values. When finding the length of the cubic through recursive measures, it is enough to carry the point at a given t to the next subdivision. (Chrome suppression has landed already.) R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1602153002 Committed: https://skia.googlesource.com/skia/+/b6474dd1a530a543ae799c3822e8bc60180761c0

Patch Set 1 #

Patch Set 2 : missed one legacy code path #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -49 lines) Patch
A gm/dashcircle.cpp View 1 chunk +78 lines, -0 lines 0 comments Download
M include/core/SkPathMeasure.h View 1 chunk +6 lines, -0 lines 0 comments Download
M samplecode/SampleQuadStroker.cpp View 7 chunks +90 lines, -8 lines 0 comments Download
M src/core/SkGeometry.h View 4 chunks +108 lines, -7 lines 0 comments Download
M src/core/SkGeometry.cpp View 3 chunks +29 lines, -15 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 1 7 chunks +100 lines, -19 lines 0 comments Download
M tests/PathMeasureTest.cpp View 1 2 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602153002/1
4 years, 11 months ago (2016-01-19 15:01:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/5328)
4 years, 11 months ago (2016-01-19 15:06:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602153002/40001
4 years, 11 months ago (2016-01-19 15:42:05 UTC) #7
caryclark
4 years, 11 months ago (2016-01-19 15:50:40 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 15:53:28 UTC) #11
reed1
I don't see how to speed it up, but can we record the perf before ...
4 years, 11 months ago (2016-01-19 16:01:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602153002/40001
4 years, 11 months ago (2016-01-19 16:07:10 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 16:07:52 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b6474dd1a530a543ae799c3822e8bc60180761c0

Powered by Google App Engine
This is Rietveld 408576698