Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1602143002: Move two more <image> related properties into CSSPropertyParser (Closed)

Created:
4 years, 11 months ago by rwlbuis
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move two more <image> related properties into CSSPropertyParser Move border-image-source/webkit-mask-box-image-source property handling from LegacyCSSPropertyParser into CSSPropertyParser. BUG=499780 Committed: https://crrev.com/c486b181d309f53357be09d81c78bf4f63b6981c Cr-Commit-Position: refs/heads/master@{#370372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rwlbuis
PTAL. This is now very easy after the border stuff has landed :-)
4 years, 11 months ago (2016-01-19 22:56:31 UTC) #3
Timothy Loh
lgtm
4 years, 11 months ago (2016-01-19 23:20:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602143002/1
4 years, 11 months ago (2016-01-19 23:38:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/161384)
4 years, 11 months ago (2016-01-20 03:49:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602143002/1
4 years, 11 months ago (2016-01-20 11:52:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 12:50:00 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 12:50:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c486b181d309f53357be09d81c78bf4f63b6981c
Cr-Commit-Position: refs/heads/master@{#370372}

Powered by Google App Engine
This is Rietveld 408576698