Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Issue 160214: Merge 21480 - Adds the first run banner.... (Closed)

Created:
11 years, 5 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
arv1
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Merge 21480 - Adds the first run banner. First run is determined by checking if there are no thumbnails. The check for no thumbnails is done on the backend since I need to add code to add some pre populated thumbnails and therefore the most visited pages will not be empty on the client. There is one edge case where the banner can show up again and that is if the user blacklists all his thumbnails and restarts chrome. Also, updates the look of the fillers to match the latest mocks. BUG=15079 TEST=Start with a new empty profile. You should see the blue first run banner. Then navigate to some link and come back the NTP. The banner should not be shown again. Also, test that this did not break the yellow notification banner shown when a thumbnail is removed. Review URL: http://codereview.chromium.org/159304 TBR=arv@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -35 lines) Patch
MM chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
MM chrome/browser/dom_ui/new_tab_ui.cc View 4 chunks +21 lines, -2 lines 0 comments Download
MM chrome/browser/resources/new_new_tab.css View 4 chunks +21 lines, -15 lines 0 comments Download
MM chrome/browser/resources/new_new_tab.js View 3 chunks +53 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 5 months ago (2009-07-27 23:08:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698