Issue 160213: Merge 21464 - Merged PipelineInternal into PipelineImpl, eliminating a ton of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160213: Merge 21464 - Merged PipelineInternal into PipelineImpl, eliminating a ton of... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, kylep, awong, brettw, scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21464 - Merged PipelineInternal into PipelineImpl, eliminating a ton of threadUNsafeness and confusion. Long story short: there's no reason to split an implementation of class between two classes. The data was being held in one class, with the other class accessing it privately without acquiring the lock. Really, really painful to debug as well. Now we have a unified implementation of Pipeline that takes care of client API requests as well as filter interaction. Since Pipeline is properly reference counted and there are two less objects to worry about, the crash reported in 3.0.195.1 should also be resolved. BUG=17107, 17548 TEST=pipeline tests, media player and chrome ui tests Review URL: http://codereview.chromium.org/159246 TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21735

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+209 lines, -333 lines)			Patch
MM	media/base/pipeline_impl.h	View	6 chunks	+100 lines, -175 lines	0 comments	Download
MM	media/base/pipeline_impl.cc	View	23 chunks	+108 lines, -154 lines	0 comments	Download
MM	media/base/pipeline_impl_unittest.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages