Issue 1602103004: Merge to XFA: Fix infinite loops caused by calling circular indirect objects

Issue 1602103004: Merge to XFA: Fix infinite loops caused by calling circular indirect objects (Closed)

Created:
4 years, 11 months ago by Wei Li

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang, jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix infinite loops caused by calling circular indirect objects There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first. BUG=pdfium:355 TBR=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1585533002 . (cherry picked from commit 90853cb1dfd1bf3803ec21cfae3e93948137be61) Committed: https://pdfium.googlesource.com/pdfium/+/6bc997a89429662668fbdce2a0d217a93e8a1be1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -111 lines)			Patch
M	core/include/fpdfapi/fpdf_objects.h	View	6 chunks	+9 lines, -26 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp	View	3 chunks	+50 lines, -85 lines	0 comments	Download
M	fpdfsdk/src/fpdfview_embeddertest.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	testing/resources/bug_355.pdf	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Wei Li

Committed patchset #1 (id:1) manually as 6bc997a89429662668fbdce2a0d217a93e8a1be1 (presubmit successful).

4 years, 11 months ago (2016-01-19 20:35:08 UTC) #3

Message was sent while issue was closed.

lgtm