Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: tests/standalone/io/raw_secure_server_socket_test.dart

Issue 16021016: dart:io | Fix issue involving SecureServerSocket error handling and HttpServer stream cancellation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add tests for cancelOnError on SecureServerSocket. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/secure_server_socket.dart ('k') | tests/standalone/io/secure_server_socket_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/raw_secure_server_socket_test.dart
diff --git a/tests/standalone/io/raw_secure_server_socket_test.dart b/tests/standalone/io/raw_secure_server_socket_test.dart
index a07083b68df07c3e197155bfae3e41006d536ad8..0b91750d5ab8b09c6c0ed4dc3de35321f3829113 100644
--- a/tests/standalone/io/raw_secure_server_socket_test.dart
+++ b/tests/standalone/io/raw_secure_server_socket_test.dart
@@ -83,7 +83,7 @@ void testSimpleConnect(String certificate) {
});
}
-void testSimpleConnectFail(String certificate) {
+void testSimpleConnectFail(String certificate, bool cancelOnError) {
ReceivePort port = new ReceivePort();
RawSecureServerSocket.bind(HOST_NAME, 0, certificate).then((server) {
var clientEndFuture = RawSecureSocket.connect(HOST_NAME, server.port)
@@ -98,8 +98,12 @@ void testSimpleConnectFail(String certificate) {
},
onError: (error) {
Expect.isTrue(error is SocketIOException);
- clientEndFuture.then((_) => port.close());
- });
+ clientEndFuture.then((_) {
+ if (!cancelOnError) server.close();
+ port.close();
+ });
+ },
+ cancelOnError: cancelOnError);
});
}
@@ -445,8 +449,10 @@ main() {
testInvalidBind();
testSimpleConnect(CERTIFICATE);
testSimpleConnect("CN=localhost");
- testSimpleConnectFail("not_a_nickname");
- testSimpleConnectFail("CN=notARealDistinguishedName");
+ testSimpleConnectFail("not_a_nickname", false);
+ testSimpleConnectFail("CN=notARealDistinguishedName", false);
+ testSimpleConnectFail("not_a_nickname", true);
+ testSimpleConnectFail("CN=notARealDistinguishedName", true);
testServerListenAfterConnect();
testSimpleReadWrite(true, true, false);
testSimpleReadWrite(true, false, false);
« no previous file with comments | « sdk/lib/io/secure_server_socket.dart ('k') | tests/standalone/io/secure_server_socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698