sdk/lib/io/secure_server_socket.dart - Issue 16021016: dart:io | Fix issue involving SecureServerSocket error handling and HttpServer stream cancellation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/secure_server_socket.dart

Issue 16021016: dart:io | Fix issue involving SecureServerSocket error handling and HttpServer stream cancellation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add tests for cancelOnError on SecureServerSocket. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/secure_server_socket.dart

diff --git a/sdk/lib/io/secure_server_socket.dart b/sdk/lib/io/secure_server_socket.dart

index 18966a34c0e851ec8bfd25a1dd06c04e6c3a70d8..e9da3c665a4ef7b292415e7d7cae5110250698a7 100644

--- a/sdk/lib/io/secure_server_socket.dart

+++ b/sdk/lib/io/secure_server_socket.dart

@@ -227,18 +227,14 @@ class RawSecureServerSocket extends Stream<RawSecureSocket> {

_controller.add(secureConnection);

}

}).catchError((e) {

- if (_closed) {

- throw e;

- } else {

+ if (!_closed) {

_controller.addError(e);

- close();

}

});

}

void _onError(e) {

_controller.addError(e);

- close();

}

void _onDone() {

« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | tests/standalone/io/raw_secure_server_socket_test.dart » ('j') | no next file with comments »