Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 16021010: make isolate accessible from returnvalue (Closed)

Created:
7 years, 7 months ago by dcarney
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

make isolate accessible from returnvalue R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14819

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -47 lines) Patch
M include/v8.h View 3 chunks +29 lines, -32 lines 1 comment Download
M src/arm/stub-cache-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
LGTM if exposing GetIsolate() is really what we want in the long run, otherwise make ...
7 years, 7 months ago (2013-05-27 11:35:36 UTC) #1
dcarney
7 years, 7 months ago (2013-05-27 11:50:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r14819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698