Issue 16021010: make isolate accessible from returnvalue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16021010: make isolate accessible from returnvalue (Closed)

Created:
7 years, 7 months ago by dcarney

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -47 lines)			Patch
M	include/v8.h	View	3 chunks	+29 lines, -32 lines	1 comment	Download
M	src/arm/stub-cache-arm.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+14 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Sven Panne

LGTM if exposing GetIsolate() is really what we want in the long run, otherwise make ...

7 years, 7 months ago (2013-05-27 11:35:36 UTC) #1

dcarney

7 years, 7 months ago (2013-05-27 11:50:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r14819 (presubmit successful).