Issue 16021003: Move StylePropertySet::createImmutable() to ImmutableStylePropertySet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16021003: Move StylePropertySet::createImmutable() to ImmutableStylePropertySet. (Closed)

Created:
7 years, 7 months ago by darktears

Modified:
7 years, 7 months ago

Reviewers:
apavlov, esprehn, eseidel

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move StylePropertySet::createImmutable() to ImmutableStylePropertySet. StylePropertySet::createImmutable() -> ImmutableStylePropertySet::create() Also, immutableCopyIfNeeded() now returns a PassRefPtr<ImmutableStylePropertySet>. This is a backport from WebKit r148398. Patch by Andreas Kling reviewed by Anders Carlsson. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151124

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -9 lines)			Patch
M	Source/core/css/CSSParser.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/StylePropertySet.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/css/StylePropertySet.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/16021003/1

7 years, 7 months ago (2013-05-24 19:08:33 UTC) #4

darktears

7 years, 7 months ago (2013-05-24 19:24:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r151124 (presubmit successful).

Expand Messages | Collapse Messages