content/browser/renderer_host/media/audio_renderer_host.cc - Issue 1602083003: Correctly handle enumerations for AudioManagers that report only the default audio output device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 1602083003: Correctly handle enumerations for AudioManagers that report only the default audio output device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_renderer_host.h ('k') | content/browser/renderer_host/media/media_stream_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_renderer_host.cc

diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc

index 49e395bd0edd694d600d280b7a72eb9568c1c043..d469d3424332a05f895eabe9299278d244c0fbea 100644

--- a/content/browser/renderer_host/media/audio_renderer_host.cc

+++ b/content/browser/renderer_host/media/audio_renderer_host.cc

@@ -840,9 +840,9 @@ void AudioRendererHost::TranslateDeviceID(

const std::string& device_id,

const GURL& security_origin,

const OutputDeviceInfoCB& callback,

- const AudioOutputDeviceEnumeration& device_infos) {

+ const AudioOutputDeviceEnumeration& enumeration) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- for (const AudioOutputDeviceInfo& device_info : device_infos) {

+ for (const AudioOutputDeviceInfo& device_info : enumeration.devices) {

if (device_id.empty()) {

if (device_info.unique_id == media::AudioManagerBase::kDefaultDeviceId) {

callback.Run(true, device_info);