Issue 160206: Fix focus bug when reloading crashed tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160206: Fix focus bug when reloading crashed tab (Closed)

Created:
11 years, 4 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The focus would be messed-up when reloading a crashed tab, also causing accelerators to be broken. This CL also makes sure to keep the focus on the location bar when reloading the NTP. BUG=http://crbug.com/14954 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21961

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -3 lines)			Patch
M	chrome/browser/browser.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browser_focus_uitest.cc	View	2 chunks	+50 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/tab_contents/tab_contents_view_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui_test_utils.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/test/ui_test_utils.cc	View	3 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages