runtime/vm/flow_graph_compiler_x64.cc - Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_x64.cc

diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc

index be0f589ccc47f2f1d27d7191a57c0d29880a97f5..d15ecea46eb52fbec7fa68fba0eaacdcaa669088 100644

--- a/runtime/vm/flow_graph_compiler_x64.cc

+++ b/runtime/vm/flow_graph_compiler_x64.cc

@@ -722,12 +722,8 @@ void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {

AddCurrentDescriptor(PcDescriptors::kDeopt,

assert->deopt_id(),

assert->token_pos());

- } else if (instr->IsGuardField()) {

- GuardFieldInstr* guard = instr->AsGuardField();

- AddCurrentDescriptor(PcDescriptors::kDeopt,

- guard->deopt_id(),

- Scanner::kDummyTokenIndex);

- } else if (instr->CanBeDeoptimizationTarget()) {

+ } else if (instr->IsGuardField() ||

+ instr->CanBecomeDeoptimizationTarget()) {

AddCurrentDescriptor(PcDescriptors::kDeopt,

instr->deopt_id(),

Scanner::kDummyTokenIndex);

« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »