Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 4068 matching lines...) Expand 10 before | Expand all | Expand 10 after
4079 __ int3(); 4079 __ int3();
4080 } 4080 }
4081 4081
4082 4082
4083 LocationSummary* GotoInstr::MakeLocationSummary() const { 4083 LocationSummary* GotoInstr::MakeLocationSummary() const {
4084 return new LocationSummary(0, 0, LocationSummary::kNoCall); 4084 return new LocationSummary(0, 0, LocationSummary::kNoCall);
4085 } 4085 }
4086 4086
4087 4087
4088 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 4088 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
4089 if (!compiler->is_optimizing()) {
4090 // Add deoptimization descriptor for deoptimizing instructions that may
4091 // be inserted before this instruction.
4092 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
4093 GetDeoptId(),
4094 0); // No token position.
4095 }
4096
4097 if (HasParallelMove()) { 4089 if (HasParallelMove()) {
4098 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 4090 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
4099 } 4091 }
4100 4092
4101 // We can fall through if the successor is the next block in the list. 4093 // We can fall through if the successor is the next block in the list.
4102 // Otherwise, we need a jump. 4094 // Otherwise, we need a jump.
4103 if (!compiler->CanFallThroughTo(successor())) { 4095 if (!compiler->CanFallThroughTo(successor())) {
4104 __ jmp(compiler->GetJumpLabel(successor())); 4096 __ jmp(compiler->GetJumpLabel(successor()));
4105 } 4097 }
4106 } 4098 }
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
4352 PcDescriptors::kOther, 4344 PcDescriptors::kOther,
4353 locs()); 4345 locs());
4354 __ Drop(2); // Discard type arguments and receiver. 4346 __ Drop(2); // Discard type arguments and receiver.
4355 } 4347 }
4356 4348
4357 } // namespace dart 4349 } // namespace dart
4358 4350
4359 #undef __ 4351 #undef __
4360 4352
4361 #endif // defined TARGET_ARCH_X64 4353 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698