Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 2689 matching lines...) Expand 10 before | Expand all | Expand 10 after
2700 } 2700 }
2701 2701
2702 2702
2703 LocationSummary* GotoInstr::MakeLocationSummary() const { 2703 LocationSummary* GotoInstr::MakeLocationSummary() const {
2704 return new LocationSummary(0, 0, LocationSummary::kNoCall); 2704 return new LocationSummary(0, 0, LocationSummary::kNoCall);
2705 } 2705 }
2706 2706
2707 2707
2708 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2708 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2709 __ TraceSimMsg("GotoInstr"); 2709 __ TraceSimMsg("GotoInstr");
2710 if (!compiler->is_optimizing()) {
2711 // Add deoptimization descriptor for deoptimizing instructions that may
2712 // be inserted before this instruction.
2713 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
2714 GetDeoptId(),
2715 0); // No token position.
2716 }
2717
2718 if (HasParallelMove()) { 2710 if (HasParallelMove()) {
2719 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 2711 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
2720 } 2712 }
2721 2713
2722 // We can fall through if the successor is the next block in the list. 2714 // We can fall through if the successor is the next block in the list.
2723 // Otherwise, we need a jump. 2715 // Otherwise, we need a jump.
2724 if (!compiler->CanFallThroughTo(successor())) { 2716 if (!compiler->CanFallThroughTo(successor())) {
2725 __ b(compiler->GetJumpLabel(successor())); 2717 __ b(compiler->GetJumpLabel(successor()));
2726 } 2718 }
2727 } 2719 }
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
2978 compiler->GenerateCall(token_pos(), 2970 compiler->GenerateCall(token_pos(),
2979 &label, 2971 &label,
2980 PcDescriptors::kOther, 2972 PcDescriptors::kOther,
2981 locs()); 2973 locs());
2982 __ Drop(2); // Discard type arguments and receiver. 2974 __ Drop(2); // Discard type arguments and receiver.
2983 } 2975 }
2984 2976
2985 } // namespace dart 2977 } // namespace dart
2986 2978
2987 #endif // defined TARGET_ARCH_MIPS 2979 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698