Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 4267 matching lines...) Expand 10 before | Expand all | Expand 10 after
4278 __ int3(); 4278 __ int3();
4279 } 4279 }
4280 4280
4281 4281
4282 LocationSummary* GotoInstr::MakeLocationSummary() const { 4282 LocationSummary* GotoInstr::MakeLocationSummary() const {
4283 return new LocationSummary(0, 0, LocationSummary::kNoCall); 4283 return new LocationSummary(0, 0, LocationSummary::kNoCall);
4284 } 4284 }
4285 4285
4286 4286
4287 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 4287 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
4288 if (!compiler->is_optimizing()) {
4289 // Add deoptimization descriptor for deoptimizing instructions that may
4290 // be inserted before this instruction.
4291 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
4292 GetDeoptId(),
4293 0); // No token position.
4294 }
4295
4296 if (HasParallelMove()) { 4288 if (HasParallelMove()) {
4297 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 4289 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
4298 } 4290 }
4299 4291
4300 // We can fall through if the successor is the next block in the list. 4292 // We can fall through if the successor is the next block in the list.
4301 // Otherwise, we need a jump. 4293 // Otherwise, we need a jump.
4302 if (!compiler->CanFallThroughTo(successor())) { 4294 if (!compiler->CanFallThroughTo(successor())) {
4303 __ jmp(compiler->GetJumpLabel(successor())); 4295 __ jmp(compiler->GetJumpLabel(successor()));
4304 } 4296 }
4305 } 4297 }
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
4708 PcDescriptors::kOther, 4700 PcDescriptors::kOther,
4709 locs()); 4701 locs());
4710 __ Drop(2); // Discard type arguments and receiver. 4702 __ Drop(2); // Discard type arguments and receiver.
4711 } 4703 }
4712 4704
4713 } // namespace dart 4705 } // namespace dart
4714 4706
4715 #undef __ 4707 #undef __
4716 4708
4717 #endif // defined TARGET_ARCH_IA32 4709 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698