Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 2773 matching lines...) Expand 10 before | Expand all | Expand 10 after
2784 __ bkpt(0); 2784 __ bkpt(0);
2785 } 2785 }
2786 2786
2787 2787
2788 LocationSummary* GotoInstr::MakeLocationSummary() const { 2788 LocationSummary* GotoInstr::MakeLocationSummary() const {
2789 return new LocationSummary(0, 0, LocationSummary::kNoCall); 2789 return new LocationSummary(0, 0, LocationSummary::kNoCall);
2790 } 2790 }
2791 2791
2792 2792
2793 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2793 void GotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2794 if (!compiler->is_optimizing()) {
2795 // Add deoptimization descriptor for deoptimizing instructions that may
2796 // be inserted before this instruction.
2797 compiler->AddCurrentDescriptor(PcDescriptors::kDeopt,
2798 GetDeoptId(),
2799 0); // No token position.
2800 }
2801
2802 if (HasParallelMove()) { 2794 if (HasParallelMove()) {
2803 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move()); 2795 compiler->parallel_move_resolver()->EmitNativeCode(parallel_move());
2804 } 2796 }
2805 2797
2806 // We can fall through if the successor is the next block in the list. 2798 // We can fall through if the successor is the next block in the list.
2807 // Otherwise, we need a jump. 2799 // Otherwise, we need a jump.
2808 if (!compiler->CanFallThroughTo(successor())) { 2800 if (!compiler->CanFallThroughTo(successor())) {
2809 __ b(compiler->GetJumpLabel(successor())); 2801 __ b(compiler->GetJumpLabel(successor()));
2810 } 2802 }
2811 } 2803 }
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
3029 compiler->GenerateCall(token_pos(), 3021 compiler->GenerateCall(token_pos(),
3030 &label, 3022 &label,
3031 PcDescriptors::kOther, 3023 PcDescriptors::kOther,
3032 locs()); 3024 locs());
3033 __ Drop(2); // Discard type arguments and receiver. 3025 __ Drop(2); // Discard type arguments and receiver.
3034 } 3026 }
3035 3027
3036 } // namespace dart 3028 } // namespace dart
3037 3029
3038 #endif // defined TARGET_ARCH_ARM 3030 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698