Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 16020013: Do not emit duplicate deoptimization entries for GotoInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 } 701 }
702 702
703 703
704 void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) { 704 void FlowGraphCompiler::EmitInstructionPrologue(Instruction* instr) {
705 if (!is_optimizing()) { 705 if (!is_optimizing()) {
706 if (FLAG_enable_type_checks && instr->IsAssertAssignable()) { 706 if (FLAG_enable_type_checks && instr->IsAssertAssignable()) {
707 AssertAssignableInstr* assert = instr->AsAssertAssignable(); 707 AssertAssignableInstr* assert = instr->AsAssertAssignable();
708 AddCurrentDescriptor(PcDescriptors::kDeopt, 708 AddCurrentDescriptor(PcDescriptors::kDeopt,
709 assert->deopt_id(), 709 assert->deopt_id(),
710 assert->token_pos()); 710 assert->token_pos());
711 } else if (instr->IsGuardField()) { 711 } else if (instr->IsGuardField() ||
712 GuardFieldInstr* guard = instr->AsGuardField(); 712 instr->CanBecomeDeoptimizationTarget()) {
713 AddCurrentDescriptor(PcDescriptors::kDeopt,
714 guard->deopt_id(),
715 Scanner::kDummyTokenIndex);
716 } else if (instr->CanBeDeoptimizationTarget()) {
717 AddCurrentDescriptor(PcDescriptors::kDeopt, 713 AddCurrentDescriptor(PcDescriptors::kDeopt,
718 instr->deopt_id(), 714 instr->deopt_id(),
719 Scanner::kDummyTokenIndex); 715 Scanner::kDummyTokenIndex);
720 } 716 }
721 AllocateRegistersLocally(instr); 717 AllocateRegistersLocally(instr);
722 } 718 }
723 } 719 }
724 720
725 721
726 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) { 722 void FlowGraphCompiler::EmitInstructionEpilogue(Instruction* instr) {
(...skipping 1005 matching lines...) Expand 10 before | Expand all | Expand 10 after
1732 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1728 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1733 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex)); 1729 __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex));
1734 } 1730 }
1735 1731
1736 1732
1737 #undef __ 1733 #undef __
1738 1734
1739 } // namespace dart 1735 } // namespace dart
1740 1736
1741 #endif // defined TARGET_ARCH_ARM 1737 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698