Issue 16020007: CSSParser should return ImmutableStylePropertySets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16020007: CSSParser should return ImmutableStylePropertySets. (Closed)

Created:
7 years, 7 months ago by darktears

Modified:
7 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

CSSParser should return ImmutableStylePropertySets. The StylePropertySets created by CSSParser were already immutable. Let this be reflected in the pointer types returned. This is a backport from WebKit r148399. Patch by Andreas Kling reviewed by Anders Carlsson. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151127

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	Source/core/css/CSSParser.h	View		4 chunks	+4 lines, -3 lines	0 comments	Download
	M	Source/core/css/CSSParser.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/16020007/1

7 years, 7 months ago (2013-05-24 19:36:27 UTC) #3

darktears

7 years, 7 months ago (2013-05-24 20:01:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r151127 (presubmit successful).

Expand Messages | Collapse Messages