Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1601973006: Split _LibrarySerializer into two classes. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split _LibrarySerializer into two classes. The new class, _CompilationUnitSerializer, is responsible for serializing a single compilation unit. In a future CL, this will allow us to serialize all the compilation units for a given library in phases, retaining state information in each of the _CompilationUnitSerializers. Also, this fixes a previously undiscovered bug where we were trying to use the same reference index to represent unresolved references across compilation units; the correct behavior is for each compilation unit to have its own index for unresolved references. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/738b835b0b62578327714558c17c5b631588f602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -222 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 16 chunks +274 lines, -220 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 2 chunks +21 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-20 04:47:43 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-20 04:52:55 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-20 05:09:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
738b835b0b62578327714558c17c5b631588f602 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698