Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issue 160196: Merge 21404 - Fix a FORWARD_NULL defect in ExtractModuleName reported by Cove... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Merge 21404 - Fix a FORWARD_NULL defect in ExtractModuleName reported by Coverity. If 'sep' is still NULL after the for loop, ix must be 1, so ix == 0 cannot be true. Update the comment for ExtractModuleName in the header to match the implementation. I don't see any code that checks whether the path is a full path. R=rvargas BUG=http://crbug.com/17101 TEST=none Review URL: http://codereview.chromium.org/155979 TBR=wtc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
MM sandbox/src/sandbox_nt_util.h View 1 chunk +3 lines, -3 lines 0 comments Download
MM sandbox/src/sandbox_nt_util.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-07-27 20:57:54 UTC) #1
wtc
11 years, 4 months ago (2009-07-27 21:59:59 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698