[Linux] Implement the crash key logging mechanism.

[Linux] Implement the crash key logging mechanism.

BUG=77656
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203006

[Robert Sesek, 2013-05-28 20:24:50]

Some background:

This implements the Linux side of
https://code.google.com/p/chromium/codesearch#chromium/src/base/debug/crash_l....
It allows developers to store arbitrary key-value pairs when crash reports are
uploaded (c.f. the bug).

After I finish the Windows version, the various global variables that are
written into BreakpadInfo (active URL, GPU info, printing info, etc.) can all be
set in a homogenized way with other platforms.

This uses a breakpad utility class I wrote (NonAllocatingMap) to store the
key-value pairs. As the name implies, this map uses fixed storage and doesn't
allocate anything. Its only call into libc is memcpy at the time of setting
values.

[Lei Zhang, 2013-05-28 22:02:24]

lgtm

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.cc
File chrome/app/breakpad_linux.cc (right):

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.cc#...
chrome/app/breakpad_linux.cc:1229: CrashKeyStorage::Iterator
crash_key_iterator(*info.crash_keys);
Can you update the comment around line 989?

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.h
File chrome/app/breakpad_linux.h (right):

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.h#n...
chrome/app/breakpad_linux.h:16: // Enables the crash reporter in child
proceseses.
nit: typo

https://codereview.chromium.org/16019015/diff/1/chrome/browser/crash_handler_...
File chrome/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/16019015/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:145: // Deleted in CrashDumpTask.
nit: Would you mind writing CrashDumpTask() to be consistent with the other
comments in the file?

https://codereview.chromium.org/16019015/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:147:
google_breakpad::SerializedNonAllocatingMap* serialzed_crash_keys;
nit: typo in var name

[Robert Sesek, 2013-05-29 18:39:45]

Thanks for the review!

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.cc
File chrome/app/breakpad_linux.cc (right):

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.cc#...
chrome/app/breakpad_linux.cc:1229: CrashKeyStorage::Iterator
crash_key_iterator(*info.crash_keys);
On 2013/05/28 22:02:24, Lei Zhang wrote:
> Can you update the comment around line 989?

Done.

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.h
File chrome/app/breakpad_linux.h (right):

https://codereview.chromium.org/16019015/diff/1/chrome/app/breakpad_linux.h#n...
chrome/app/breakpad_linux.h:16: // Enables the crash reporter in child
proceseses.
On 2013/05/28 22:02:24, Lei Zhang wrote:
> nit: typo

Done.

https://codereview.chromium.org/16019015/diff/1/chrome/browser/crash_handler_...
File chrome/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/16019015/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:145: // Deleted in CrashDumpTask.
On 2013/05/28 22:02:24, Lei Zhang wrote:
> nit: Would you mind writing CrashDumpTask() to be consistent with the other
> comments in the file?

Done.

https://codereview.chromium.org/16019015/diff/1/chrome/browser/crash_handler_...
chrome/browser/crash_handler_host_linux.cc:147:
google_breakpad::SerializedNonAllocatingMap* serialzed_crash_keys;
On 2013/05/28 22:02:24, Lei Zhang wrote:
> nit: typo in var name

Done.

[commit-bot: I haz the power, 2013-05-29 21:29:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/16019015/17001

[commit-bot: I haz the power, 2013-05-29 23:43:13]

Change committed as 203006